Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump contract builder to version 1.61 #821

Merged
merged 2 commits into from
May 20, 2022
Merged

Conversation

austinabell
Copy link
Contributor

1.60 is needed to be able to build the nearcore crates used for unit testing after #820 as can be seen from this failed buildkite https://buildkite.com/nearprotocol/near-sdk-rs/builds/4076#090f7030-7abe-48bf-80a0-95fbce8f323f

This adds more value to https://github.com/near/near-ops/issues/839 since using latest and bumping people's images based on this for updates like this isn't a good pattern. cc @anshal-savla

Also noting that changes like this would break old CI runs on this repo since the toolchain is different and would produce different binaries -- there should be a way to specify the Rust toolchain version on the image tag

@austinabell austinabell requested a review from itegulov May 19, 2022 14:05
Copy link
Contributor

@itegulov itegulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use Rust 1.61 that came out today? Regardless, LGTM

@austinabell
Copy link
Contributor Author

Any reason not to use Rust 1.61 that came out today? Regardless, LGTM

Nope, didn't notice it had been released. Will update to that

@austinabell austinabell changed the title chore: bump contract builder to version 1.60 chore: bump contract builder to version 1.61 May 20, 2022
@austinabell austinabell merged commit 83cd668 into master May 20, 2022
@austinabell austinabell deleted the austin/docker160 branch May 20, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants