chore: update workspaces to 0.3 #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I left some TODOs in nft and ft examples that should now be resolvable with workspaces 0.2. You could tackle them in this PR or I can do it in a follow up PR, up to you |
I'll separate that change since this is blocking #742 |
austinabell
changed the title
ChaoticTempest
approved these changes
May 11, 2022
| @@ -27,25 +27,25 @@ async fn init( | |||
| initial_balance: U128, | |||
| ) -> anyhow::Result<(Contract, Account, Contract)> { | |||
| let ft_contract = | |||
| worker.dev_deploy(include_bytes!("../res/fungible_token.wasm").to_vec()).await?; | |||
| worker.dev_deploy(&include_bytes!("../res/fungible_token.wasm").to_vec()).await?; | |||
There was a problem hiding this comment.
looks like you forgot to clean some of these up:
Suggested change
| worker.dev_deploy(&include_bytes!("../res/fungible_token.wasm").to_vec()).await?; | |
| worker.dev_deploy(include_bytes!("../res/fungible_token.wasm")).await?; |
itegulov
approved these changes
May 12, 2022
Comment on lines
86
to
+90
| let wasm = fs::read("res/callback_results.wasm").await?; | ||
|
|
||
| let worker = workspaces::sandbox(); | ||
| let worker = workspaces::sandbox().await?; | ||
|
|
||
| let contract = worker.dev_deploy(wasm).await?; | ||
| let contract = worker.dev_deploy(&wasm).await?; |
There was a problem hiding this comment.
any reason not to use include_bytes! here?
There was a problem hiding this comment.
tried to keep this change unopinionated, can follow with that change in another
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP since test is broken