Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove clone from Promise API #783

Merged
merged 5 commits into from
Apr 8, 2022
Merged

fix: Remove clone from Promise API #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ab369e
fix: Remove clone from Promise API
austinabell Apr 7, 2022
bd6a1a2
changelog
austinabell Apr 7, 2022
d6c9622
merge
austinabell Apr 8, 2022
70e073f
switch section to remove
austinabell Apr 8, 2022
869f8d1
merge
austinabell Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
- Fixed gas assertion in `*_transfer_call` implementations of FT and NFT standards to only require what's needed. [PR 760](https://github.com/near/near-sdk-rs/pull/760)
- Fixed events being emitted in FT standard to include refund transfers and burn events. [PR 752](https://github.com/near/near-sdk-rs/pull/752)

### Removed
- Remove `Clone` implementation for `Promise` (error prone) https://github.com/near/near-sdk-rs/pull/783

## [4.0.0-pre.7] - 2022-02-02

### Features
Expand Down
Binary file modified examples/callback-results/res/callback_results.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified examples/cross-contract-calls/res/cross_contract_high_level.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified examples/factory-contract/res/factory_contract_high_level.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified examples/fungible-token/res/defi.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified examples/fungible-token/res/fungible_token.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified examples/non-fungible-token/res/approval_receiver.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified examples/non-fungible-token/res/non_fungible_token.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified examples/non-fungible-token/res/token_receiver.wasm
View file
Open in desktop
Binary file not shown.
1 change: 0 additions & 1 deletion near-sdk/src/promise.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ impl PromiseJoint {
/// .transfer(1000)
/// .add_full_access_key(env::signer_account_pk());
/// ```
#[derive(Clone)]
pub struct Promise {
subtype: PromiseSubtype,
should_return: RefCell<bool>,
Expand Down