NFT Events Standard #652
Closed
NFT Events Standard #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenKurrek
requested review from
austinabell,
ChaoticTempest and
evgenykuzyakov
as code owners
near-contract-standards/src/non_fungible_token/core/core_impl.rs
Outdated
Show resolved
Hide resolved
near-contract-standards/src/non_fungible_token/core/core_impl.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Phuong Nguyen <[email protected]>
near-contract-standards/src/non_fungible_token/core/core_impl.rs
Outdated
Show resolved
Hide resolved
near-contract-standards/src/non_fungible_token/core/core_impl.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Phuong Nguyen <[email protected]>
austinabell
reviewed
Dec 1, 2021
near-contract-standards/src/non_fungible_token/core/core_impl.rs
Outdated
Show resolved
Hide resolved
Comment on lines
284
to
285
| if !approval_id.is_none() { | ||
| authorized_id = Some(sender_id.to_string()); |
There was a problem hiding this comment.
Suggested change
| if !approval_id.is_none() { | |
| authorized_id = Some(sender_id.to_string()); | |
| if approval_id.is_some() { | |
| authorized_id = Some(sender_id.to_string()); |
There was a problem hiding this comment.
Should this not be an AccountId instead of a string?
Comment on lines
294
to
295
| old_owner_id: owner_id.to_string(), | ||
| new_owner_id: receiver_id.to_string(), |
There was a problem hiding this comment.
same with these, can/should they not be an AccountId for some reason?
…ixed all the warnings
Co-authored-by: Austin Abell <[email protected]>
austinabell
reviewed
Dec 1, 2021
|
@BenKurrek |
I didn't know this was being worked on until I was almost finished. Perhaps we can combine our PRs into one. :) |
|
@BenKurrek You could use log functions from my PR to update the implementations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the events standard for the non-fungible-token core standards.
Fixes (#649)