feat: Add new syscalls and move to separate crate #507
Conversation
austinabell
requested review from
ChaoticTempest,
evgenykuzyakov and
mikedotexe
as code owners
|
new clippy version causes warnings, will fix in a separate PR (#508) |
|
Is this part of the broader goal to have an efficient "under layer" to the SDK so folks can optionally build no_std contracts? |
Yes, it is. Let me link the issue here: #463 |
| @@ -31,16 +34,25 @@ extern "C" { | |||
| pub fn sha256(value_len: u64, value_ptr: u64, register_id: u64); | |||
| pub fn keccak256(value_len: u64, value_ptr: u64, register_id: u64); | |||
| pub fn keccak512(value_len: u64, value_ptr: u64, register_id: u64); | |||
| pub fn ripemd160(value_len: u64, value_ptr: u64, register_id: u64); | |||
| pub fn ecrecover( | |||
There was a problem hiding this comment.
I wonder if we can't just link the docs from nearcore directly into these sys calls. I feel like it would be a painpoint eventually for someone who's trying to optimize their contracts but not directly know what all these syscalls are, and have to indirectly discover near-vm-logic/logic.rs to understand them
There was a problem hiding this comment.
yeah definitely would be some value add here. Definitely a niche use case for someone to be using syscalls directly, but I will open an issue for this
There was one function I didn't add, which is
gas(u64)which just consumes gas, as I didn't see any benefit. Happy to add if anyone can think of a reason, but I don't see any usage of it anywhere.I won't release this crate until this is approved, just to be safe