-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nft): switch nft traits to not require moving underlying struct #475
Conversation
We'll likely need to update the |
I'm not certain, but I think all of these functions are generated with the impl macro so won't need to change anything unless you override methods. I could be wrong though |
Oh if its in the macro, then it should be fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't quite sure of the motivation to not use &
and prefer this approach. I think perhaps there was an idea of having self
be captured, but think this is in line with what we have elsewhere. Thanks
self
eitherI also bumped the version so that I can make the minor release after it comes incan't actually release this change unless I cherry-pick on top of the previous version, this contains other changes not released