feat(collections): Lazy storage value #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
chadoh,
evgenykuzyakov and
mikedotexe
as code owners
austinabell
changed the title
|
per our discussions, I will be moving this type to the new module. The name is still not specified, so either |
matklad
reviewed
May 12, 2021
near-sdk/Cargo.toml
Outdated
| @@ -29,6 +29,9 @@ near-primitives-core = "=0.4.0" | |||
| # Export dependencies for contracts | |||
| wee_alloc = { version = "0.4.5", default-features = false, features = [] } | |||
|
|
|||
| # Used for caching, might be worth porting only functionality needed. | |||
| once_cell = { version = "1.7.2", optional = true } | |||
There was a problem hiding this comment.
Suggested change
| once_cell = { version = "1.7.2", optional = true } | |
| once_cell = { version = "1.7.2", optional = true, default-features = false } |
I think need only no_std (single threaded ) version.
|
|
evgenykuzyakov
approved these changes
May 13, 2021
mikedotexe
reviewed
May 18, 2021
| @@ -0,0 +1,91 @@ | |||
| use borsh::{BorshDeserialize, BorshSerialize}; | |||
|
|
|||
| use super::Lazy; | |||
mikedotexe
reviewed
May 18, 2021
| /// This will only write to the underlying store if the value has changed, and will only read the | ||
| /// existing value from storage once. | ||
| /// | ||
| /// # Examples |
There was a problem hiding this comment.
Again appreciate these doc examples
mikedotexe
approved these changes
May 18, 2021
This was referenced May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #406 this implements the lazy storage type, which is similar to
LazyOptionexcept that the assertion that the value exists in storage is maintained by the API to allow easier usage for developers.This PR re-uses the cache entry type from #402 (with small adjustments) to solidify that API and ensure it can be used for other types. Also for simplicity, this brings in the
once_cellcrate for lazily filling the cache cell under the feature flag, but only specific logic needed can be ported over to minimize compiled size if necessary.