Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(json_types): impl FromStr for public key json types and cleanup #400

Merged
merged 8 commits into from
May 11, 2021
Merged

feat(json_types): impl FromStr for public key json types and cleanup #400

merged 8 commits into from
May 11, 2021

Conversation

austinabell
Copy link
Contributor

  • Implements FromStr for CurveType and Base58PublicKey
  • Switches deserialization intermediate type to Cow
  • Document type (was unclear to me what exactly was supported)

@austinabell austinabell changed the title feat: impl FromStr for public key json types and cleanup feat(json_types): impl FromStr for public key json types and cleanup May 10, 2021
@mikedotexe mikedotexe merged commit dd1da9c into near:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenykuzyakov evgenykuzyakov evgenykuzyakov approved these changes

@mikedotexe mikedotexe mikedotexe approved these changes

@chadoh chadoh Awaiting requested review from chadoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austinabell @evgenykuzyakov @mikedotexe