Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix new lints, introduced in 1.78 #1181

Merged
merged 3 commits into from
May 21, 2024
Merged

ci: fix new lints, introduced in 1.78 #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22109b1
ci: fix new 1.78 lints
May 7, 2024
64efdcf
test: `schemars` version update, `TRYBUILD=overwrite`
May 7, 2024
e6f38c3
Update schema_derive_invalids.stderr with schemars-0.8.20
frol May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/fungible-token/test-contract-defi/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ pub struct DeFi {
}

// Have to repeat the same trait for our own implementation.
#[allow(dead_code)]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value_please on line 57 is called on DeFiExt , so the lint is correct here

trait ValueReturnTrait {
fn value_please(&self, amount_to_return: String) -> PromiseOrValue<U128>;
}
Expand Down
2 changes: 1 addition & 1 deletion near-sdk-macros/src/core_impl/info_extractor/attr_sig_info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ impl AttrSigInfo {

self_occurrences.extend(args.iter().flat_map(|arg| arg.self_occurrences.clone()));

*original_attrs = non_bindgen_attrs.clone();
original_attrs.clone_from(&non_bindgen_attrs);

if matches!(method_kind, MethodKind::Call(_) | MethodKind::View(_)) {
report_spans(
Expand Down
2 changes: 1 addition & 1 deletion near-sdk/compilation_tests/schema_derive_invalids.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ error[E0277]: the trait bound `Inner: JsonSchema` is not satisfied
i128
and $N others
note: required by a bound in `SchemaGenerator::subschema_for`
--> $CARGO/schemars-0.8.17/src/gen.rs
--> $CARGO/schemars-0.8.20/src/gen.rs
|
| pub fn subschema_for<T: ?Sized + JsonSchema>(&mut self) -> Schema {
| ^^^^^^^^^^ required by this bound in `SchemaGenerator::subschema_for`
1 change: 1 addition & 0 deletions near-sdk/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#![allow(clippy::redundant_closure)]
// We want to enable all clippy lints, but some of them generate false positives.
#![allow(clippy::missing_const_for_fn, clippy::redundant_pub_crate)]
#![allow(clippy::multiple_bound_locations)]

#[cfg(test)]
extern crate quickcheck;
Expand Down
Loading