Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Currently there is an error in the type
PromiseIndex
. Currently it is defined as(number | bigint) & PromiseIndexBrand
. Since&
is the intersection operator, and thatPromiseIndexBrand == -1
, then the only valid value is-1
.This is an error since
PromiseIndex
is used to access a Promise Result, which is at lease0
(if it exists).We caught this with @gagdiez while testing the
cross contract calls
example. Notice that the error was not captured before because it only arises in Typescript (and not in JS, which the currentXCC
example is written in).Test Plan
Added a new version of the
cross contract call
written in TSRelated issues/PRs
#379