Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Storage Management to FT Example #253

Merged
merged 19 commits into from
Oct 13, 2022
Merged

Add Storage Management to FT Example #253

merged 19 commits into from
Oct 13, 2022

Conversation

idea404
Copy link
Contributor

@idea404 idea404 commented Oct 4, 2022

This PR adds storage management to the fungible-token example.

It also changes the naming of public functions to snake_case thus matching naming conventions for Rust smart contracts.

@idea404 idea404 self-assigned this Oct 4, 2022
@idea404 idea404 added the enhancement New feature or request label Oct 4, 2022
ailisp
ailisp approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @idea404 . This is a great addition to FT to avoid exhaust-storage-deposit attack. Can you fix the lint so we can merge it?

volovyks
volovyks reviewed Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idea404 thanks for working on this!
nits:

  • please, remove package.lock file, yarn.lock is enouth
  • changes to yarn.lock are not necessary, since there is no changes in package.json
  • linter is not happy

examples/src/fungible-token.js Show resolved Hide resolved
examples/src/fungible-token.js Outdated Show resolved Hide resolved
examples/src/fungible-token.js Outdated Show resolved Hide resolved
examples/src/fungible-token.js Outdated Show resolved Hide resolved
examples/src/fungible-token.js Outdated Show resolved Hide resolved
examples/src/fungible-token.js Outdated Show resolved Hide resolved
examples/src/fungible-token.js Outdated Show resolved Hide resolved
examples/src/fungible-token.js Outdated Show resolved Hide resolved
examples/src/fungible-token.js Outdated Show resolved Hide resolved
idea404 added 17 commits October 11, 2022 14:05
@idea404
remove supply === 0 assertion from init
97842a0
@idea404
add validation for accountId in init
9f6619a
@idea404
remove internal send near same account as contr assert
ba5f8d0
@idea404
abstract repeated assertions
d4e443d
@idea404
remove package-lock
1f78279
@idea404
revert changes in yarn.lock
3f08b2a
@idea404
use high level promise API
5f21d33
@idea404
update to TS
5832324
@idea404
remove type from var names and add type to assertion params
7d27f50
@idea404
underscore FT helper class name
75cbb6a
@idea404
lint ft contract
19fb884
@idea404
format code
972cb40
@idea404
use dynamic storage on accountId length
0f05f83
@idea404
Merge branch 'develop' of https://github.com/near/near-sdk-js into ft…
44b77a1 
…-example-improvement
@idea404
implement constructor
d295b6e
@idea404
Merge branch 'develop' of https://github.com/near/near-sdk-js into ft…
dabae98 
…-example-improvement
@idea404
save numerical values as bigint
0adb4cc
volovyks
volovyks approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! And thanks for refactoring it.

@volovyks volovyks merged commit 56d31cc into develop Oct 13, 2022
@ailisp ailisp deleted the ft-example-improvement branch October 14, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volovyks volovyks volovyks approved these changes

@ailisp ailisp ailisp approved these changes

Assignees

@idea404 idea404

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idea404 @volovyks @ailisp