Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump GH action runners to ubuntu-20.04 #63

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Conversation

morgsmccauley
Copy link
Collaborator

@morgsmccauley morgsmccauley commented Feb 7, 2023

ubuntu-18.04 will be deprecated soon, they have already started introducing brown-outs which are causing our PR checks to fail.

This PR bumps the GH Action runner-images to ubuntu-20.04, this is the same version the lake nodes are running in GCP, so shouldn't have any impact, but I'll do some tests to verify. cross docker version shouldn't need to be updated as it's only the GH runners which are affected.

CHANGELOG.md Outdated
@@ -1,5 +1,9 @@
# Changelog

## 0.1.20

* Upgrade Indexer Framework to be based on [nearcore 1.31.0](https://github.com/near/nearcore/commit/1c6fa351a6f285734835cc1e7c9f0a03e38ca49b)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's worth to be upgraded to 1.31.1 already, would you mind?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR wasn't meant to include this commit, I forgot to point it to #62. I'll merge this PR just with the CI fixes and create a new PR for 1.31.1.

@morgsmccauley morgsmccauley force-pushed the ci/ubuntu-latest branch 2 times, most recently from 86a0d48 to dbe42b5 Compare February 21, 2023 21:49
@morgsmccauley
Copy link
Collaborator Author

@khorolets The required check needs to be updated

- test (linux-x86_64, ubuntu-18.04, stable, x86_64-unknown-linux-gnu)
+ test (linux-x86_64, ubuntu-20.04, stable, x86_64-unknown-linux-gnu)

Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we expected that "linux"-something job to be completed?

@morgsmccauley
Copy link
Collaborator Author

I wonder whether we expected that "linux"-something job to be completed?

@khorolets That job will never run, it's the old job which is specified in the repo settings marking it as a required check. Matrix jobs specify the variables in the title, so since we've upgraded to 20.04, it's considered a new job, while the repo still expects the 18.04 job to run.

This is why I've suggested to change the required check here: #63 (comment)

@morgsmccauley morgsmccauley merged commit c8ac63d into main Feb 22, 2023
@morgsmccauley morgsmccauley deleted the ci/ubuntu-latest branch February 22, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants