Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of Coins, use FT instead #52

Merged
merged 2 commits into from
Dec 15, 2022
Merged

get rid of Coins, use FT instead #52

merged 2 commits into from
Dec 15, 2022

Conversation

telezhnaya
Copy link
Contributor

While solving one more issue of Coin interface, I've decided to get rid of this concept and use FT instead.

What does it mean for the user:

  • We planned to serve FTs and MTs together: we no longer want to do that. So, they need to query FTs and MTs separately. The truth is, for now, we don't have MT support anyway. When MT support will be ready, we will consider making additional endpoints and combining all of them together.
  • "Get Coin Balances" had both FT and native NEAR in the response. Now we have 2 separate endpoints for that. Let's go with this solution and add one more endpoint later if users ask for it.
  • The paths changed a bit, but, since we don't have active users for now, I'm OK with bringing breaking changes

@telezhnaya
Copy link
Contributor Author

What I want to be reviewed here:

  • New endpoints list. There were NFT and Coins previously, now it looks this way:

Screenshot 2022-12-15 at 11 18 56

- Paths. Unfortunately, github can't build diff, you need to look at 3 files below. Before: https://github.com/near/near-enhanced-api-server/blob/main/src/modules/coin/mod.rs After: https://github.com/near/near-enhanced-api-server/blob/no_coins/src/modules/ft/mod.rs https://github.com/near/near-enhanced-api-server/blob/no_coins/src/modules/native/mod.rs

@telezhnaya
Copy link
Contributor Author

We had a call with @khorolets , finalised the interfaces and I've also added #53

@telezhnaya telezhnaya merged commit 0eb387c into main Dec 15, 2022
@telezhnaya telezhnaya deleted the no_coins branch December 15, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants