-
Notifications
You must be signed in to change notification settings - Fork 95
[v4.0.0] Reorganize, Reduce and Enhance #1082
Conversation
Lots of good changes. Nice work @gagdiez! |
Edit: For Ledger, I saw it added a lot of complexity to the code... thought I might be evaluating the situation wrong here. Also, don't want a Ledger to be connected to a project with minimum support. |
@gagdiez |
@volovyks should we then implement Otherwise, we can remove it now, and bring it back later if anyone was handling their staking through the CLI (which again, would be weird, since they cannot unstake it through there later) |
Merged since it is simpler to start fixing this version that keep working on the previous one (for example, TLA account creation is now broken) |
This is a proposal for a new major version of
near-cli
.The main change is that the code was re-organized so it is simpler to maintain:
commands
folder.The second change is that the complexity of
near-cli
was reduced by removing a couple of features:x-api
option.stake
command.evm
commands.Ledger
support.validator
commands.walletUrl
,nodeUrl
andhelperUrl
options.dev-deploy
command. Users must now create an account (can fund it with a faucet) and deploy to it.The third change is that Errors are now handled on each command, and not through some obscure middleware.
The fourth change is that a couple of fixes were implemented:
create-account
can now createTLA
,sub-accounts
and.testnet/.near
accounts. The user can choose to fund the new account with an existing account or with a faucet service.MyNearWallet
install ofNearWallet
--networkId
flag, now it works as expected (i.e. switches network) in all relevant commands.Fifth: besides the removal of commands explained in the second point, there is just one more breaking change:
generate-key
command does not save the key by default, now it needs the--saveImplicit
flag to save the key. Also, it does not overwrite the key if it exists, it needs the--force
flag for that.