Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockup: add vesting info, add graphs with schedule to the doc #691

Merged
merged 6 commits into from
Jun 16, 2021

Conversation

telezhnaya
Copy link
Contributor

@telezhnaya telezhnaya commented May 13, 2021

Let's review the contents, then we will ask the designer to re-draw the pictures.

I added info about vesting, reordered things a little, added graphs.

UPD: Here is a direct link to the updated documentation page for your convenience: https://docs-pr-691.onrender.com/docs/tokens/lockup

@telezhnaya telezhnaya requested review from frol and yessins May 13, 2021 09:54
@render
Copy link

render bot commented May 13, 2021

@telezhnaya telezhnaya requested review from eriktrautman and removed request for yessins May 13, 2021 15:18
@telezhnaya
Copy link
Contributor Author

@eriktrautman I am updating technical documentation for our lockup contract
near/core-contracts#144

I decided that it's crucial to update high-level doc as well. All the comments are highly appreciated.

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks more accurate and specific to me now!

My nits are just about "Phase 2" being usually spelled as "Phase II" in our posts.

docs/tokens/lockup.md Outdated Show resolved Hide resolved
docs/tokens/lockup.md Outdated Show resolved Hide resolved
docs/tokens/lockup.md Outdated Show resolved Hide resolved
@telezhnaya telezhnaya changed the title Add graphs with vesting/unlocking to lockup.md lockup: add vesting info, add graphs with schedule to the doc May 14, 2021
Co-authored-by: Vlad Frolov <[email protected]>
@telezhnaya
Copy link
Contributor Author

@frol @eriktrautman I added pictures that Jake sent me. Please have a look.

I also fixed Phase II date, it was the evening of Oct 13. Now it's correct both in text and on pictures.

docs/tokens/lockup.md Outdated Show resolved Hide resolved
docs/tokens/lockup.md Outdated Show resolved Hide resolved
docs/tokens/lockup.md Outdated Show resolved Hide resolved
docs/tokens/lockup.md Outdated Show resolved Hide resolved
docs/tokens/lockup.md Outdated Show resolved Hide resolved
docs/tokens/lockup.md Outdated Show resolved Hide resolved
docs/tokens/lockup.md Outdated Show resolved Hide resolved
docs/tokens/lockup.md Outdated Show resolved Hide resolved
docs/tokens/lockup.md Outdated Show resolved Hide resolved
docs/tokens/lockup.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants