feat: implement schema for arrays and fix box bounds #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
approved these changes
Jun 25, 2021
ailisp
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Looks good!
Edit: Also noticed usize and isize aren't implemented for schema it seems, ideas on if this should be an issue, completed in this PR, or ignored?
It should be added. usize was originally not part of borsh, so does borsh schema. Later usize is added (treat as u64), but didn't add for borsh schema
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[T]types andstrVec<T>but let me know if something else is ideal. I couldn't useArray<T, len>because the type itself doesn't have a sizeEdit: Also noticed
usizeandisizearen't implemented for schema it seems, ideas on if this should be an issue, completed in this PR, or ignored?