-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom type support for int and uint #4
Conversation
555a0a5
to
1672340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yihau Thanks for the contribution!
I don't have deep experience with Go to reason about all the shortcomings, but the code looks reasonable to me 👍
It looks correct to me now. Great! Last thing, I wonder if first calling |
here is the benchstat between master and my branch
serialize is more efficient because get the value directly |
LGTM |
Hi, is there any news on this? |
I think it's safe to merge now. Thanks for the contribution! @yihau |
I found that It will panic when I serialize and deserialize including custom type. I add some support for these types: