-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump @ckeditor/ckeditor5-vue from 6.0.0 to 7.0.0 #898
Merged
basil
merged 4 commits into
master
from
dependabot/npm_and_yarn/ckeditor/ckeditor5-vue-7.0.0
Aug 10, 2024
Merged
chore: bump @ckeditor/ckeditor5-vue from 6.0.0 to 7.0.0 #898
basil
merged 4 commits into
master
from
dependabot/npm_and_yarn/ckeditor/ckeditor5-vue-7.0.0
Aug 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
added
the
Type: Dependencies
Dependency issues or Changes to dependency files
label
Aug 7, 2024
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/ckeditor/ckeditor5-vue-7.0.0
branch
from
August 7, 2024 21:02
561fe3a
to
ab6a21b
Compare
@dependabot rebase |
Bumps [@ckeditor/ckeditor5-vue](https://github.com/ckeditor/ckeditor5-vue) from 6.0.0 to 7.0.0. - [Release notes](https://github.com/ckeditor/ckeditor5-vue/releases) - [Changelog](https://github.com/ckeditor/ckeditor5-vue/blob/master/CHANGELOG.md) - [Commits](ckeditor/ckeditor5-vue@v6.0.0...v7.0.0) --- updated-dependencies: - dependency-name: "@ckeditor/ckeditor5-vue" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/ckeditor/ckeditor5-vue-7.0.0
branch
from
August 10, 2024 18:44
ab6a21b
to
0c2bb25
Compare
basil
reviewed
Aug 10, 2024
@@ -54,7 +54,6 @@ | |||
|
|||
<script lang="ts"> | |||
import { FontSizeOption } from '@ckeditor/ckeditor5-font/src/fontconfig'; | |||
import { CKEditorComponentData } from '@ckeditor/ckeditor5-vue/dist/ckeditor'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in ckeditor/ckeditor5-vue#281. I tried migrating this to
diff --git a/src/components/TextBoxRich.vue b/src/components/TextBoxRich.vue
index e8b5f69..134ce32 100644
--- a/src/components/TextBoxRich.vue
+++ b/src/components/TextBoxRich.vue
@@ -54,6 +54,7 @@
<script lang="ts">
import { FontSizeOption } from '@ckeditor/ckeditor5-font/src/fontconfig';
+import { Ckeditor } from '@ckeditor/ckeditor5-vue';
import { EditorConfig } from 'ckeditor5';
import { StyleValue } from 'vue';
import { Component, Prop, Vue } from 'vue-facing-decorator';
@@ -106,19 +107,19 @@ export default class TextBoxRich extends Vue {
}
get editorInstance() {
- return (this.$refs.editor as any)?.instance;
+ return (this.$refs.editor as typeof Ckeditor)?.instance;
}
get editorInstanceLeft() {
- return (this.$refs.editorLeft as any)?.instance;
+ return (this.$refs.editorLeft as typeof Ckeditor)?.instance;
}
get editorInstanceCenter() {
- return (this.$refs.editorCenter as any)?.instance;
+ return (this.$refs.editorCenter as typeof Ckeditor)?.instance;
}
get editorInstanceRight() {
- return (this.$refs.editorRight as any)?.instance;
+ return (this.$refs.editorRight as typeof Ckeditor)?.instance;
}
get content() {
but this didn't work. Not sure what I'm missing here.
I found the solution buried in vuejs/language-tools#3206 and vuejs/core#4397. Now pardon me while I go back to Java development… |
dependabot
bot
deleted the
dependabot/npm_and_yarn/ckeditor/ckeditor5-vue-7.0.0
branch
August 10, 2024 20:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps @ckeditor/ckeditor5-vue from 6.0.0 to 7.0.0.
Release notes
Sourced from
@ckeditor/ckeditor5-vue
's releases.... (truncated)
Changelog
Sourced from
@ckeditor/ckeditor5-vue
's changelog.... (truncated)
Commits
550fa81
Release: v7.0.0.2ee5bba
Merge pull request #302 from ckeditor/release-20240807063bd83
Changelog for v7.0.0.5fc488a
Docs: Changelog. [skip ci]b72b20b
Added missingfrom
option for changelog script.da8058c
Release: v7.0.0-alpha.2.cf0b5f1
Merge pull request #298 from ckeditor/release-alpha-20241707dc855a3
Docs: Changelog. [skip ci]eba73a5
Merge pull request #295 from ckeditor/rename-global-namee2a9bbc
Merge pull request #296 from ckeditor/fix-typingsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)