Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap mooseErrors to paramErrors #989

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

nuclearkevin
Copy link
Contributor

This PR swaps mooseError(...) calls with paramError(...) calls where it makes sense to do so. Combined parameter errors (where two input parameters aren't compatible or something similar) don't work with the paramError paradigm, and so they were left as mooseErrors. This is a first pass over all of the generic and OpenMC objects; I haven't gone over the Nek objects to avoid any potential clashes in #987.

Annoyingly some RunException tests needed to be re-golded as they were failing pattern matching once the errors they tested were swapped to paramErrors. This is why a few test files are modified in this PR.

- Making this change in neutronics classes and generic classes to avoid any clashes with the upcoming nek update
@moosebuild
Copy link
Collaborator

Job Precheck, step Clang format on ea4ced1 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/989/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 18ee4b68cda263f9e8dfc19a3250c06e9faf9e87

@moosebuild
Copy link
Collaborator

Job Documentation, step Sync to remote on fe1a109 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Collaborator

Job Coverage, step Generate coverage on fe1a109 wanted to post the following:

Coverage

18ee4b #989 fe1a10
Total Total +/- New
Rate 92.92% 92.91% -0.02% 80.77%
Hits 7747 7753 +6 42
Misses 590 592 +2 10

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 80.77% is less than the suggested 90.0%

This comment will be updated on new commits.

@aprilnovak aprilnovak merged commit 90d08e7 into neams-th-coe:devel Nov 23, 2024
9 checks passed
@nuclearkevin nuclearkevin deleted the swap_to_param_errors branch November 23, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants