Compatible with meteor 1.3?

[johhansantana]

Hello there.

With the release of Meteor 1.3, I was wondering if this generator is compatible with it as I've been using it with Meteor 1.2.

Thanks!

[ndxbxrme]

hey @JSantana90

the generator currently makes a huge mess of meteor1.3

i've created a new branch to work on compatibility
https://github.com/ndxbxrme/generator-angular-meteor/tree/meteor1point3
any help would be appreciated

[johhansantana]

ok, I'm currently studying the best way to structure a meteor 1.3 app, I will try to help in my spare time.

[ndxbxrme]

that would be great!

[huss22]

Hi,

I think it has to do with the modules package. As it forces you to follow best practices. Which isn't automatically loaded as part of the update to 1.3 as of 1.3.2.2. I successfully updated my project to 1.3.2.2 without the issues you see above and I was seeing before. Let me know if I can help test, I created a fresh project and updated without issues to confirm it's working.

Tested with:
? What would you like to write scripts with? JavaScript
? What would you like to write markup with? HTML
? What would you like to write stylesheets with? CSS
? Would you like pagination, sorting and searching support? Yes
? Select a CSS framework Angular Material
? Would you like to include Bower package management support? Yes
? Would you like to use user authentication? Yes
? Would you like to include additional oAuth strategies? Google, Facebook, Twitter

After that, I did meteor update and removed the dotansimha:accounts-ui-angular package as it is still relying on angular 1.2.7 and remove accounts.ui dependency from app.ng.js

Result attached.

[ndxbxrme]

hi Hasnain

that's really interesting
i'll give it a try tonight

[donedgardo]

@huss22 @ndxbxrme
From mquandalle/meteor-bower:

This package is deprecated in favor of Meteor 1.3+ NPM support and we recommend that you migrate > your existing applications using this bower package to Meteor 1.3 NPM.

Best choice is to remove the question.

[huss22]

@donedgardo I think the issue I was having was more related to the modules package in meteor 1.3 and dotansimha:accounts-ui-angular, but agree with you on removing bower as well from the generator for 1.3 as it's no longer supported.

But I would suggest keeping the question open until the generator can successfully handle 1.3?

[donedgardo]

@huss22 working on it atm, goint to change to angular-babel that comes with ng-annotate and use npm import syntax for angular, angular-meteor

[mikkelking]

I took the work done already by Edgardo Carreras @donedgardo to remove Bower, and took the last references out.

When you first run the generator, it does a "meteor create", which unfortunately creates a main.js, main.html and main.css, which is part of the problem.

I have forked the repo to https://github.com/mikkelking/generator-angular-meteor which directly loads Meteor 1.3.2.4

This still blows up, but can be fixed with the following steps:

rm client/main.*
meteor update

• It will tell you the packages that are behind their latest versions, upgrade them with a command like this:

meteor update  angular:angular angular:angular-animate angular:angular-aria dburles:mongo-collection-instances lai:collection-extensions pbastowski:angular-babel tmeasday:check-npm-versions

(This set is for angular-material, your packages may/will be dfferent)

If you stay with the original repo, the above approach still works, so getting to Meteor 1.3 isn't too hard.

If anyone knows how to fix/automate these steps please let me know how :)

Cheers

Mike

[mikkelking]

I took the above and integrated them into the generator, so it works smoothly now. I have done a pull request to get these changes merged.

[ndxbxrme]

hey guys
the generator(v0.21.0) is now 1.3 compatible
thanks for all your input!

[mikkelking]

Thanks Kieron, good work, any more changes in the pipeline?

[ndxbxrme]

cheers mike
the next thing on my list is to try and clear this warning

i thought it was being caused by the angular version number having an underscore in it, but i'm not so sure now
after that i'd like to integrate e2e tests and tidy up the templates a bit

[mikkelking]

That's a pretty old version of angular it is expecting. It will be an
npm package dependency that needs to be updated to get with Angular
1.5+. I'll try and find time to look

I ran the new version up, and it generates new pages ok, but doesn't
update the menus, so right now you manually need to update the
navigation buttons to integrate it. I was wondering if a list of the
pages could be stored in the .yorc, and then when a page is added, this
list is updated, and a list of pages be saved to JSON, and the nav menu
would do an ng-repeat to display nav buttons from that list.

Mike

On 17/06/2016 4:57 PM, kieron wright wrote:

cheers mike
the next thing on my list is to try and clear this warning
image
https://cloud.githubusercontent.com/assets/8391259/16142846/d85624f8-3460-11e6-8774-a6b97674789e.png
i thought it was being caused by the angular version number having an
underscore in it, but i'm not so sure now
after that i'd like to integrate e2e tests and tidy up the templates a bit

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#43 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACWoT3kPF1scJOC6XWGDldIa30TUNHQZks5qMkVqgaJpZM4IBJHY.

[ndxbxrme]

i love the idea of auto generating menus and it's something i've considered before but i came to the conclusion that they are out of the scope of this project.
things like menus and redirection are very subjective and every dev handles them differently. i don't think we could provide a solution that would work well for everyone.
sorry to be such a downer:(

the angular version warning only rears it's ugly head when user authentication is selected so the problem lies somewhere in accounts-password, dotansimha:accounts-ui-angular or accounts.ui