Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --numeric-version flag. #62

Closed
wants to merge 1 commit into from
Closed

Add --numeric-version flag. #62

wants to merge 1 commit into from

Conversation

pjonsson
Copy link
Contributor

The json output flag just added is meant for other tools. Adding --numeric-version, which is also meant for tools, in the same release seems reasonable. This change allows HLint to preserve the numeric-version behaviour across different releases of cmdargs.

I hacked the flag into main mode. I'm not sure if it should go elsewhere--it's definitely a common flag. Setting the group name for the flag alters the group name for the entire mode rather than putting the numeric-version flag in the common section.

I still have the TODO for cmdargs support on my list, but haven't gotten around to that yet.

@ndmitchell
Copy link
Owner

I'm tempted to say let's put this in cmdargs directly, and not bother with a temporary hack to hlint - I worry once I have added it to cmdargs, then HLint might go a bit weird. I suggest we delay the next HLint release until:

And probably aiming for a Wed/Thur release, if that suits you two?

@pjonsson
Copy link
Contributor Author

I'm good with anything that gives 1.9.1 a --numeric-version option. If we're in a hurry and you have the spare cycles for the cmdargs hacking that is probably the quickest way to get things moving.

@ndmitchell
Copy link
Owner

Btw, by putting it in cmdargs, it will be dependent on someones cmdargs version whether they have --numeric-version, so I still recommend you check both --numeric-version and fallback to --version for the next few months.

@pjonsson
Copy link
Contributor Author

You do not plan to increase the lower bound for cmdargs for the next HLint release?

@ndmitchell
Copy link
Owner

My plan would be not to bother (it just makes upgrading for users slightly harder), but if it makes a difference to you I'll do so.

@pjonsson
Copy link
Contributor Author

Nah, leave it as it is. I'll close this ticket since it really belongs in cmdargs.

@pjonsson pjonsson closed this Jul 20, 2014
@ndmitchell
Copy link
Owner

@pjonsson @carymrobbins I've just released cmdargs with support for --numeric-version and HLint with the --json flag. Let me know if you need anything else.

@carymrobbins
Copy link
Contributor

This is great, thanks @ndmitchell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants