Replace the ghc-lib flag with a subcomponent #1378
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1376 by creating a subcomponent
hlint:ghclib
that replaces theghc-lib
flag. This enables other packages upstream to declaratively select which "version" ofhlint
they need, e.g. HLS: pepeiborra/ide@637aa0bA priori, there is no downside to introducing the
ghclib
component:hlint
binary doesn't pull theghclib
componentBut there might be some hidden costs. Most tooling struggles with Cabal subcomponents. I don't know if
stack
can handle them, for instance.