Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the ghc-lib flag with a subcomponent #1378

Closed
wants to merge 1 commit into from

Conversation

pepeiborra
Copy link
Contributor

Addresses #1376 by creating a subcomponent hlint:ghclib that replaces the ghc-lib flag. This enables other packages upstream to declaratively select which "version" of hlint they need, e.g. HLS: pepeiborra/ide@637aa0b

A priori, there is no downside to introducing the ghclib component:

  1. Building the hlint binary doesn't pull the ghclib component
  2. No additional Hackage upload required

But there might be some hidden costs. Most tooling struggles with Cabal subcomponents. I don't know if stack can handle them, for instance.

@shayne-fletcher
Copy link
Collaborator

@pepeiborra #1410 has been accepted that flips the ghc-lib flag default to True. given past discussions i think then we might choose to abandon this PR now and close it out?

@pepeiborra pepeiborra closed this Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants