Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1324 add createModuleExWithFixities #1325

Merged
merged 3 commits into from
Jan 2, 2022
Merged

#1324 add createModuleExWithFixities #1325

merged 3 commits into from
Jan 2, 2022

Conversation

eddiemundo
Copy link
Contributor

Fixes #1324

@eddiemundo eddiemundo mentioned this pull request Dec 10, 2021
Merged
ndmitchell
ndmitchell reviewed Dec 12, 2021
View reviewed changes
Copy link
Owner

@ndmitchell ndmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I'll hold off on merging it until we get the GHC 9.2 transition completed, but looks good to merge then. Hopefully won't take too long (a few days)

src/GHC/All.hs Outdated Show resolved Hide resolved
@ndmitchell
Copy link
Owner

Could you also rebase following the move to GHC 9.2.

@eddiemundo eddiemundo force-pushed the createModuleExWithFixities branch from 29fa6b2 to 9f34fc0 Compare December 13, 2021 00:40
@ndmitchell ndmitchell merged commit 3e13d07 into ndmitchell:master Jan 2, 2022
@ndmitchell
Copy link
Owner

Thanks - will be in the next release, which needs to wait for GHC 9.2 compatibility support, so might be a month or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndmitchell ndmitchell ndmitchell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A way to createModuleEx with config fixities?
2 participants
@eddiemundo @ndmitchell