fix: various fixes #738
Merged
fix: various fixes #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takinbo
requested changes
Sep 22, 2020
apollo/submissions/services.py
Outdated
| sorted(submission.participant.phone_contacts, key=lambda p: p.updated, reverse=True)[0].number # noqa | ||
| if submission.participant and | ||
| submission.participant.phone_contacts else '', | ||
| submission.last_phone_number, |
There was a problem hiding this comment.
We should store safe values if the submission does not have a value for last_phone_number.
There was a problem hiding this comment.
the property defaults to None, which is output as an empty string
apollo/submissions/services.py
Outdated
| sib.participant.phone_contacts[0].number | ||
| if sib.participant and sib.participant.phone_contacts | ||
| else '', | ||
| sib.last_phone_number, |
There was a problem hiding this comment.
Set a safe value in case a value for last_phone_number is not available.
this pull request attempts to address: - nditech/apollo-issues#89, where the "recent phone" was inaccurate - nditech/apollo-issues#90, where the "db phone" and "recent phone" were to be updated - nditech/apollo-issues#91, where a specific order for participant phone numbers was to be set - nditech/apollo-issues#92, where the "db phone" and "recent phone" for location submission export was to match the observer export
dodumosu
force-pushed
the
participant-fixes
branch
from
8d42cef to
4a5b150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request attempts to address: