-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIT #142
Comments
- Add pit - Add pit-tests Resolves #142
Looks like the code from JIVE has been copied in which is useful. I just noticed a couple of quick things, that maybe are non-issues but just dropping them here for future reference:
|
Thanks @nikeethr. @rob-taggart also has some ideas on how the implementation can be improved before it's merged onto develop. |
Extracting references:
|
Wikipedia definition Just going to dump my notes to sound out my understanding, and add/correct them in further comments as my knowledge improves. So don't assume these as fact: Assuming that the wikipedia definition is accurate (without direct access to its references), here are some foundations:
|
The integrals discussed in #142 (comment) are actually more about approximating continuous integration with computations over finite bins. The PIT while a general concept, in our application actually pertains to "measurable sets", and the domain applied over "measurable functions". As such, alternatives to the Riemann integral (the one used in calculus and I was intending approximations for in the linked post) are: Jordan, Borel, W. H. Young, Lebesgue, and potentially more - that can be applied to measurable sets. I'm not sure how much of this the original code uses or needs knowledge of this (since the final equations maybe easily representable as basic sums - again more reading required). Regardless, the Lebesgue measure forms some of foundation and derivation of PIT in various linear/non-linear strategies: https://doi.org/10.1214/13-EJS823 |
Intuitive analysis i. Probability is a measure of likelihood of an event happening, its measurements are in the range If we look at the definition of a CDF for a extended positive real domain: In particular, rainfall intuitively is a composite of at least two measurable functions or distributions Follow ups:
|
Intuitive analysis ii. Before going into the follow-ups it may be worth considering how an implementation for a "naïve" case would look like. We first define some primitive constraints:
Then, naturally we can compose a measurement function of a pdf for rainfall for the contrived example. For rainfall with point mass at
If we formulate the constraints this way, it allows for extensibility to arbitrary definitions prior to computing the |
Aside: A quick look at the current implementation shows that the Additionally, the integrals used in the implementation are mainly for variance calculations in the |
Migrate the PIT function across from Jive.
The text was updated successfully, but these errors were encountered: