feature: add configurable master instance settings #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nchammas can this be merged in some form? it would be nice to have this feature - depending on the application, the master doesn't really need to be very beefy, but having bigger slaves can be better for performance (to a certain extent) |
|
My apologies to both @luhhujbb and @devyn about leaving this PR hanging. I won't have the capacity in the foreseeable future to review and shepherd this PR through to completion. I would consider running a fork of Flintrock to get this feature. The instructions in the README should help you build your own version. If you have trouble doing that, please reach out and I will try to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Fully tested on our production environment
Fixes #82.