Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected display name for 'Blob Containers Allowing Public Access' #1612

Merged
merged 1 commit into from
May 8, 2024
Merged

Corrected display name for 'Blob Containers Allowing Public Access' #1612

merged 1 commit into from
May 8, 2024

Conversation

rieck-srlabs
Copy link
Contributor

Description

This commit changes the UI description for the Azure rule 'Blob Containers Allowing Public Access'. The UI incorrectly specified that the rule scans Storage Accounts, while it actually scans 'Blob Containers'. Since there are potentially more Blob Containers than Storage Accounts, the reported statistics are incorrect.

Fixes #1608

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

The test scans Blob Containers, not Storage Accounts.
There is a 1:n relationship between Storage Accounts and Blob Containers.
@fernando-gallego fernando-gallego self-assigned this May 8, 2024
@fernando-gallego fernando-gallego merged commit cba4cc0 into nccgroup:develop May 8, 2024
@rieck-srlabs rieck-srlabs deleted the bugfix/1608-improve-blob-container-labeling branch May 13, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants