Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Get the correct type for skos concepts #162

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Nov 17, 2022

Issue

If we take as an example the NLMVS ontology, which is SKOS terminology with only SKOS Concepts (no OWL ontology)

But when we check one of its concepts like Intraspinal abscess (disorder) , our API tell us that is of @type: "owl:Class" (see screenshot below)

image

This PR fix that, by displaying the correct type, skos:Concept if SKOS and owl:Class if Ontology

After

image

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #162 (81c7977) into master (b5057b4) will decrease coverage by 0.02%.
The diff coverage is 70.00%.

❗ Current head 81c7977 differs from pull request most recent head ba7a7f8. Consider uploading reports for the commit ba7a7f8 to get more accurate results

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   80.75%   80.72%   -0.03%     
==========================================
  Files          63       63              
  Lines        4848     4857       +9     
==========================================
+ Hits         3915     3921       +6     
- Misses        933      936       +3     
Flag Coverage Δ
unittests 80.72% <70.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ontologies_linked_data/serializers/json.rb 79.22% <70.00%> (-1.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syphax-bouazzouni syphax-bouazzouni changed the title Get the correct type for skso concepts Get the correct type for skod concepts Nov 17, 2022
@syphax-bouazzouni syphax-bouazzouni changed the title Get the correct type for skod concepts Get the correct type for skos concepts Nov 17, 2022
@syphax-bouazzouni syphax-bouazzouni changed the title Get the correct type for skos concepts Feature: Get the correct type for skos concepts May 18, 2024
@alexskr alexskr changed the base branch from master to develop May 22, 2024 18:07
@alexskr
Copy link
Member

alexskr commented Jul 17, 2024

already implemented via PR #199 36a5b68

@alexskr alexskr closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants