Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bug in the get_rest_mapping method #156

Merged

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Sep 5, 2022

Prerequisite

Issue

We have a bug in the get_rest_mapping method when the replace_url_prefix is enabled. Where the mappings can't be found by their id.

To reproduce

This PR comes with its correspondent unit test, that you can see to reproduce the bug.

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #156 (dc35d50) into master (8196bf3) will increase coverage by 0.04%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   80.84%   80.88%   +0.04%     
==========================================
  Files          63       63              
  Lines        4835     4856      +21     
==========================================
+ Hits         3909     3928      +19     
- Misses        926      928       +2     
Flag Coverage Δ
unittests 80.88% <90.90%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ontologies_linked_data/serializers/xml.rb 68.96% <0.00%> (ø)
lib/ontologies_linked_data/mappings/mappings.rb 81.94% <100.00%> (ø)
lib/ontologies_linked_data/models/base.rb 71.96% <100.00%> (+4.25%) ⬆️
lib/ontologies_linked_data/monkeypatches/object.rb 71.73% <100.00%> (+1.68%) ⬆️
lib/ontologies_linked_data/serializers/json.rb 80.88% <100.00%> (ø)
...tologies_linked_data/models/ontology_submission.rb 78.74% <0.00%> (-0.55%) ⬇️
lib/ontologies_linked_data/metrics/metrics.rb 79.70% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syphax-bouazzouni syphax-bouazzouni changed the title Fix a bug in the get_rest_mapping method Fix: bug in the get_rest_mapping method Sep 14, 2022
Copy link
Member

@mdorf mdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging...

@mdorf mdorf merged commit e00c4e3 into ncbo:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants