-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: bug in the get_rest_mapping method #156
Fix: bug in the get_rest_mapping method #156
Conversation
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 80.84% 80.88% +0.04%
==========================================
Files 63 63
Lines 4835 4856 +21
==========================================
+ Hits 3909 3928 +19
- Misses 926 928 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, merging...
Prerequisite
Issue
We have a bug in the get_rest_mapping method when the replace_url_prefix is enabled. Where the mappings can't be found by their id.
To reproduce
This PR comes with its correspondent unit test, that you can see to reproduce the bug.