replace delete_if with select

to avoid modifying the original array, which prevents issues with frozen arrays, fixes #161 "FrozenError - can't modify frozen Array" (part 2)
ncbo · Sep 27, 2024 · f98bead · f98bead
1 parent 16d50db
commit f98bead
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/helpers/application_helper.rb b/helpers/application_helper.rb
@@ -125,10 +125,10 @@ def reply(*response)
         check_access(obj) if LinkedData.settings.enable_security
 
         # Slice or set check
-        filter_for_slice(obj) if LinkedData.settings.enable_slices
+        obj = filter_for_slice(obj) if LinkedData.settings.enable_slices
 
         # Check for custom ontologies set by user
-        filter_for_user_onts(obj)
+        obj = filter_for_user_onts(obj)
 
         LinkedData::Serializer.build_response(@env, status: status, ld_object: obj)
       end
@@ -211,8 +211,8 @@ def restricted_ontologies(params=nil)
 
           found_onts = onts.length > 0
 
-          filter_for_slice(onts)
-          filter_for_user_onts(onts)
+          onts = filter_for_slice(onts)
+          onts = filter_for_user_onts(onts)
         end
         onts = filter_access(onts)
 

diff --git a/helpers/users_helper.rb b/helpers/users_helper.rb
@@ -12,7 +12,7 @@ def filter_for_user_onts(obj)
         user = env["REMOTE_USER"]
 
         if obj.first.is_a?(LinkedData::Models::Ontology)
-          obj.delete_if {|o| !user.custom_ontology_id_set.include?(o.id.to_s)}
+          obj = obj.select {|o| user.custom_ontology_id_set.include?(o.id.to_s)}
         end
 
         obj
@@ -21,4 +21,4 @@ def filter_for_user_onts(obj)
   end
 end
 
-helpers Sinatra::Helpers::UsersHelper
+helpers Sinatra::Helpers::UsersHelper