Add code coverage report uploads to codecove.io

[alexskr]

No description provided.

[syphax-bouazzouni]

Hi @alexskr ,

did you fix the tests issues ?

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (develop@1ef7367). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #126   +/-   ##
==========================================
  Coverage           ?   85.27%           
==========================================
  Files              ?       20           
  Lines              ?     2037           
  Branches           ?        0           
==========================================
  Hits               ?     1737           
  Misses             ?      300           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[alexskr]

Hi @syphax-bouazzouni,
@stdotjohn made some progress so unit tests now pass

[syphax-bouazzouni]

Hi @syphax-bouazzouni, @stdotjohn made some progress so unit tests now pass

Ah ok great,
thanks @stdotjohn and @alexskr

[alexskr]

We still have a bunch of disabled tests but at least there is some progress

[ncbo-deployer]

Four tests are skipped. The slice_loading_size logic makes it look four times bigger (for 16 skipped tests) but is irrelevant. The tests have the following explanations: 1. TestChunkWrite.rb#test_reentrant_queries – This is not a good test and probably can’t be fixed. It runs up against threading issues and currently fails because a “long” running thread is done too early. 2. TestCollection#test_inverse_on_collection – This test says “Not supported inverse on collection” 3. TestComplex::TestModelComplex#test_aggregate – This test involves transitive closure and doesn’t work as written. I will see if I can make it work with AllegroGraph as their reasoner supports the OWL construct of transitively closed properties. 4. TestReadOnly::TestReadOnlyWithStruct#test_embed_struct has the attached comment “not yet” and was not further investigated. The last three tests will be re-evaluated on the switch to AllegroGraph.

…

-Timothy From: bioontology-admin ***@***.***> on behalf of Alex Skrenchuk ***@***.***> Date: Wednesday, November 16, 2022 at 11:33 PM To: ncbo/goo ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [bioontology-admin] [ncbo/goo] Add code coverage report uploads to codecove.io (PR #126) We still have a bunch of disabled tests but at least there is some progress — Reply to this email directly, view it on GitHub<#126 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAP2LDW7XG3RKU26A5ADMKLWIXNUTANCNFSM6AAAAAASDBJEZ4>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[syphax-bouazzouni]

A remark, see 0e09816#commitcomment-90304626

Hi @stdotjohn ,

I agree with your problem discription "the classes constraint was not covered", but i don't think that disabling it is the fix (and may break the ontologies_linked_data models).

For information also, here the constrain :class for an attribute means it will be instanciate as a Class resource (owl:Class , not the ruby class)

This behavior is done the else state of the switch

goo/lib/goo/validators/enforce.rb

Lines 98 to 113 in 0e09816

	else
	model_range = opt.respond_to?(:shape_attribute) ? opt : Goo.model_by_name(opt)
	if model_range and !value.nil?
	values = value.kind_of?(Array) ? value : [value]
	values.each do |v|
	if (!v.kind_of?(model_range)) && !(v.respond_to?(:klass) && v[:klass] == model_range)
	add_error(model_range.model_name, errors_by_opt,
	"`#{attr}` contains values that are not instance of `#{model_range.model_name}`")
	else
	if !v.respond_to?(:klass) && !v.persistent?
	add_error(model_range.model_name, errors_by_opt,
	"`#{attr}` contains non persistent models. It will not save.")
	end
	end
	end
	end

@mdorf can give a second review of this