Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscribe to notes emails button should redirect to login for anonymous users #298

Closed
jvendetti opened this issue Dec 8, 2023 · 1 comment · Fixed by #301
Closed

Subscribe to notes emails button should redirect to login for anonymous users #298

jvendetti opened this issue Dec 8, 2023 · 1 comment · Fixed by #301
Assignees
@jvendetti
Labels
bug

Comments

@jvendetti
Copy link
Member

Steps to reproduce:

  1. Navigate to any ontology summary page in BioPortal (make sure you're not logged in)
  2. Navigate to the top-level Notes tab
  3. Click the "Subscribe to notes emails" button

This results in a 500 error from the server because we call the subscriptions endpoint with undefined values, e.g.:

/subscriptions?user_id=undefined&ontology_id=undefined&subbed=undefined

Clicking on the button should redirect to the login page for anonymous users.
@jvendetti jvendetti self-assigned this Dec 8, 2023
@jvendetti jvendetti added the bug label Dec 8, 2023
@jvendetti
Copy link
Member Author

jvendetti commented Dec 8, 2023 •
edited
Loading

Additional notes on this button / functionality:

  • We should display a flash message to indicate whether or not subscription succeeded
  • If subscription is successful, we need to update the button text immediately. Currently you can only see that the text changed to "Unsubscribe to notes emails" if you reload the page.

jvendetti added a commit that referenced this issue Dec 13, 2023
@jvendetti
Fix login requirement for notes email subscriptions
783f335 
The sanitize method was stripping the href attribute. See #298.
jvendetti added a commit that referenced this issue Dec 13, 2023
@jvendetti
Fix Uncaught TypeError on notes emails subscribe
4856bf9 
See #298
@jvendetti jvendetti mentioned this issue Dec 15, 2023
Merged
jvendetti added a commit that referenced this issue Jan 16, 2024
@jvendetti @alexskr
Sync: bring OntoPortal up-to-date with BioPortal releases 6.13.2 and …
58bd5df 
…onward (#17)

* Bump bootstrap from 4.1.0 to 5.2.3

* Refactor home page cards

* Refactor top navigation bar

* Fix close buttons on dismissible alerts

* Refactor sticky footer code

* Repair Admin tabbed interface

* Refactor form to fix spacing issues

* Remove unused styles

* Remove unnecessary nested fluid container

* Refactor form to fix spacing issues

* Fix alignment issue with annotator plus spinner

* Fix broken tabbed navigation for ontology tabs

* Remove text decoration in the ontology info bar

* Clean up display of ontology information buttons

* Restore bold font in ontology metadata cards

* Restore bold font for submissions header

* Remove anchor text decoration for metadata cards

* Restore border at the top of the submissions table

* Remove bottom border from show more subs cell

* Restore top borders to details and metrics tables

* Fix add proposal dropdown button

* Fix class permalink dialog

* Fix create new mapping dialog

* Fix add and remove synonym dialogs

* Adjust buttons on create mapping dialog

* Refactor create new mapping form

* Add back platforms overwritten during merge

* Refactor horizontal form to fix spacing issues

* Restore padding in class details pane

* Refactor class search form to fix spacing issues

* Restore appearance of search links

* Restore left alignment in ontology column

* add download link for OntoPortal Virtual Appliance v3.2.1

* Restore link appearance in ontology column

* Refactor form to fix spacing and alignment issues

* Fix footer layout and presentation issues

* Remove text-decoration for ontology visits

Also prevent wrapping of column header text

* Fix node obsoletion form

* Fix node rename form

* jQuery toggle no longer needed

* Fix create and remove synonym dialog forms

* Fix jump to input group

* Remove text decoration for details and mappings

* Replace Uglifier with Terser

Fixes Uglifier::Error that prevents asset precompilation

* Pin graphql gem to less than 2.1

* Pin base64 gem to 0.1.0

See #293

* Remove text decoration from ontology list

* Restore space underneath filter text box

* Add download link for Virtual Appliance v3.2.2

* Use regular dropdown instead of split type

* Display site notices above loading splash div

Prevents a jumpy page appearance when the ontologies loading message is displayed

* Update Gemfile.lock

* Adjust font size for autocomplete results list

Resolves #296

* Fix login requirement for notes email subscriptions

The sanitize method was stripping the href attribute. See #298.

* Encode user ID portion of subscriptions params

Resolves #300

* Fix Uncaught TypeError on notes emails subscribe

See #298

* Fix some RuboCop warnings

* Refactor subscribed_to_ontology? method

Account for the case where the user parameter doesn't have the ontology attribute loaded on the list of associated subscription objects

---------

Co-authored-by: Alex Skrenchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvendetti jvendetti

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix various issues with notes emails subscriptions ncbo/bioportal_web_ui
1 participant
@jvendetti