Use github.com/prometheus/procfs #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 8, 2020
|
Hi @PierreF thanks for doing this. Would you mind removing the |
|
Updated (push-force) to remove the replace line. |
PierreF
changed the title
|
Thanks again @PierreF ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #140, use upsteam prometheus/procfs.
This depend on PR prometheus/procfs#280 and that's why the go.mod contains a replace pointing to my fork of prometheus/procfs. We should wait for prometheus/procfs to merge the PR and I'll update go.mod to drop the replace before merging this PR.
All changes in vendor/ directory were done by running "go mod vendor" using go 1.12.17. I hope it's the correct way to update it.