Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataclasses and code speedup #3

Merged
merged 78 commits into from
Dec 20, 2024
Merged

dataclasses and code speedup #3

merged 78 commits into from
Dec 20, 2024

Conversation

ali-izhar
Copy link
Contributor

simplified code structure api and experiment module adding dataclasses, dynamic model registry for torchvision models and ultralytics, dynamic inference utils.

@nbovee
Copy link
Owner

nbovee commented Nov 22, 2024

Pretty happy with what we have so far, current notes:

  • local only fallback on device_config.yaml needed so we can run simple integration tests before being fully configured
  • similar fallbacks for defaults on other scripts within ./tests
  • high change I introduced a lot of off-by-one errors in the hook changes since I couldn't test them without full configs today
  • looking into still keeping this installable, but adding a simple cli command to dump configs in current directory so we can still use pypi
  • if python 3.11 can be we used as our lower bound we could swap configs to toml files with stdlib additions
  • uv.lock tends to need de-duping and locks up, for the time being I have been doing uv lock | uv sync --extra cpu to clean and rebuild it

@nbovee
Copy link
Owner

nbovee commented Nov 23, 2024

just read further into our template files, now I know why you though I was crazy asking for the current configs!

Copy link
Owner

@nbovee nbovee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging in to staging, rolling into main after checking readmes

@nbovee nbovee merged commit 1abb82b into nbovee:staging Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants