Validate issue line number

nbihan-mediware · Nov 29, 2018 · 471a0f0 · 471a0f0
1 parent ab702a2
commit 471a0f0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -1,5 +1,5 @@
 pipeline {
-    agent any  
+    agent any
     stages {
         stage('Clean') {
            steps {

diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
     <groupId>com.stepstone.sonar.plugin</groupId>
     <artifactId>sonar-coldfusion-plugin</artifactId>
     <packaging>sonar-plugin</packaging>
-    <version>1.6.2-SNAPSHOT</version>
+    <version>1.6.3-SNAPSHOT</version>
 
     <name>SonarQube Coldfusion Analyzer</name>
     <description>Enables scanning of ColdFusion source files</description>

diff --git a/src/main/java/com/stepstone/sonar/plugin/coldfusion/cflint/CFlintAnalysisResultImporter.java b/src/main/java/com/stepstone/sonar/plugin/coldfusion/cflint/CFlintAnalysisResultImporter.java
@@ -91,7 +91,7 @@ private void handleIssueTag(IssueAttributes issueAttributes) throws XMLStreamExc
                     LocationAttributes locationAttributes = new LocationAttributes(stream);
                     InputFile inputFile = fs.inputFile(fs.predicates().hasAbsolutePath(locationAttributes.getFile().get()));
                     if(inputFile == null){
-                        LOGGER.error("File {} is null",locationAttributes.getFile().get());
+                        LOGGER.error("File {} is null", locationAttributes.getFile().get());
                     }
                     createNewIssue(issueAttributes, locationAttributes, inputFile);
                 }
@@ -113,6 +113,11 @@ private void createNewIssue(IssueAttributes issueAttributes, LocationAttributes
             return;
         }
 
+        if(locationAttributes.getLine().isPresent() && locationAttributes.getLine().get()>inputFile.lines()){
+            LOGGER.error("Problem creating issue for file {}, issue is line {} but file has {} lines", inputFile, locationAttributes.getLine().get(), inputFile.lines());
+            return;
+        }
+
         LOGGER.debug("create New Issue {} for file {}", issueAttributes, inputFile.filename());
         final NewIssue issue = sensorContext.newIssue();