Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Angular 17 #185

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Migrate to Angular 17 #185

merged 2 commits into from
Jan 11, 2024

Conversation

ArtemDintecom
Copy link
Contributor

In addition to the new Angular, I tried to return the standard-version, replacing it with commit-and-tag-version.
For this to work you will need to manually create the v4.0.0 tag on commit 1b561bc.
Then before the new version is released it will be possible to run npm run release -- --release-as major.
It was great to sync the major version of ngx-currency with the Angular version and release version 17 instead of 5. More and more libraries are coming to this, and this is very convenient for developers because libraries usually do not declare backward compatibility.

Closes #183, #184

@mtosic
Copy link

mtosic commented Nov 17, 2023

Hi @ArtemDintecom , is there any way to use your fork from npm before it's merged?
I've tried npm install git+https://github.com/dintecom/ngx-currency#upgrade, but on build process I'm getting errors on importing import { NgxCurrencyInputMode, provideEnvironmentNgxCurrency } from 'ngx-currency'; (module can't be found).

Guess I need to build library myself (from fork), but not sure how to do it.

@ArtemDintecom
Copy link
Contributor Author

@mtosic Yes, you can use it by adding this to package.json:

  "dependencies": {
    ...
    "ngx-currency": "https://github.com/dintecom/ngx-currency-dist#v17.0.0-1",
    ...
  }

NPM doesn't always understand these links well, so you may have to clean out the node_modules folder and install the packages again with npm install.

@mtosic
Copy link

mtosic commented Nov 17, 2023

Thx, that worked!

@vtregner-cen29414
Copy link

Can you merge and release new version pls?

@nbfontana nbfontana merged commit ef7a545 into nbfontana:master Jan 11, 2024
@ArtemDintecom ArtemDintecom deleted the upgrade branch June 3, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0.0 changelog
4 participants