Change encoding for json.loads #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nbering, can this patch be merged? Python 3.9 is out since early October this year and it is only a matter of time before it starts rolling out into distros. |
|
@nbering Are you able to get this merged? I am using @obilodeau solution to work on python 3.9 |
|
@dverbeek84, for the record, this is not my patch. It is @emrahcetiner's. It can be quickly applied like this: cd YOUR_TERRAFORM.PY_LOCATION
wget https://patch-diff.githubusercontent.com/raw/nbering/terraform-inventory/pull/20.diff
patch -p1 < 20.diff
rm 20.diff@nbering: Arch Linux is now on Python 3.9. |
|
Any update on this? Homebrew Python is on 3.9 and this script fails |
|
Fedora 34 is Py3.9 now too so it's broken there as well without this patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove encoding argument from json.loads for support to pyhton 3.9 #19