Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAY-9 Emit Key State Change Events #3

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

amarinkovic
Copy link
Member

@amarinkovic amarinkovic commented Apr 16, 2024

To validate the proper deployment and initialisation of the contracts, it is a good practice to emit events. Also, any
important state transitions can be logged, which is beneficial for monitoring the contract and tracking eventual bugs or hacks.

Added events emitting when the storage variables sysAdmins and minter are updated.

@amarinkovic amarinkovic changed the title NAY-9 Emit Key State Change Events NAY-9 Emit Key State Change Events [CU-8694ay43q] Apr 16, 2024
@amarinkovic amarinkovic changed the title NAY-9 Emit Key State Change Events [CU-8694ay43q] NAY-9 Emit Key State Change Events Apr 16, 2024
Copy link
Collaborator

@kevin-fruitful kevin-fruitful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amarinkovic amarinkovic merged commit 5076f13 into audit_fixes_qs3 Apr 24, 2024
2 checks passed
@amarinkovic amarinkovic deleted the NAY-9-state-change-events branch April 24, 2024 12:37
@amarinkovic amarinkovic mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants