Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked msg for user and otp should not sent to bloked user #9

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

walmadhagi
Copy link

@walmadhagi walmadhagi commented Nov 14, 2024

Description

This PR separates the error messaging for blocked users from the recovery flow. Previously, blocked users were receiving the same messaging as users in the recovery flow, which could be confusing and potentially insecure.

Changes

  • Created distinct error handling for blocked user accounts
  • Removed recovery code generation for blocked users
  • Updated error messages to provide clearer guidance for blocked accounts

Security Impact

This change improves security by:

  • Preventing recovery codes from being sent to blocked accounts
  • Providing clear messaging that directs blocked users to contact system administrators
  • Reducing potential confusion between account recovery and account blocking states

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aalkhodiry aalkhodiry merged commit 94d72a9 into master Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants