Add Inactive account endpoint #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds functionality to automatically deactivate identities that have been inactive for a configurable period. Key changes: - Add config option for inactivity threshold period - Add API endpoint to list and deactivate inactive identities - Add SQL queries to find and update inactive identities - Add manager and persister methods to handle deactivation
|
@aalkhodiry For the schema version source I was able to point to nayla version by adding this comment at the top of # yaml-language-server: $schema=https://raw.githubusercontent.com/nayla-finance/kratos/refs/heads/master/.schema/version.schema.json |
aalkhodiry
reviewed
Nov 5, 2024
| "id": id.ID, | ||
| "state": id.State, | ||
| "created_at": id.CreatedAt, | ||
| "updated_at": id.UpdatedAt, |
There was a problem hiding this comment.
I think this should include a last activity field some how (like last_session_at)
There was a problem hiding this comment.
Yes I agree it'll be easier to add a last_active_at to identities table and update it on every login which will make the lookup for inactive much easier. with this we don't need to keep at least one session for each identity we can just run a job to delete all the sessions every few days
There was a problem hiding this comment.
No not like this, I mean last_active_at is the max session time in the query
aalkhodiry
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inactive Account Management
Changes Made
Why
To enhance security and resource management by automatically identifying and handling dormant accounts. This feature allows administrators to:
Technical Details