Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VENOM-361: Distribute avatar #364

Merged
merged 3 commits into from
May 14, 2018
Merged

VENOM-361: Distribute avatar #364

merged 3 commits into from
May 14, 2018

Conversation

naxuroqa
Copy link
Owner

@naxuroqa naxuroqa commented May 14, 2018

  • Add a file chooser for avatars
  • Set avatar resolution to 128x128
  • Add a filter for images to filechooser
  • Add callbacks to ToxAdapterSelfListener
  • Fix tox avatars directory position
  • Fix bug in FileTransferListener preventing user from sending files
  • Rework user_info_widget, add avatars from /usr/share/pixmaps/faces
  • Send avatar to all online contacts immediately
  • Send to offline contacts when they come online

closes #361

naxuroqa added 3 commits May 13, 2018 18:44
* Set avatar resolution to 128x128
* Add a filter for images to filechooser
* Add callbacks to ToxAdapterSelfListener
* Fix avatars directory position
* Rework user_info_widget, add avatars from `faces`
* Send avatar to all online contacts immediately
* Send to offline contacts when they come online
@codecov-io
Copy link

codecov-io commented May 14, 2018

Codecov Report

Merging #364 into develop will decrease coverage by 16.99%.
The diff coverage is 2.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #364     +/-   ##
==========================================
- Coverage    37.69%   20.69%    -17%     
==========================================
  Files           49       90     +41     
  Lines         2876     5237   +2361     
==========================================
  Hits          1084     1084             
- Misses        1792     4153   +2361
Impacted Files Coverage Δ
src/core/UserInfo.vala 0% <0%> (ø)
src/core/FileTransfer.vala 4.8% <0%> (-0.35%) ⬇️
src/viewmodel/UserInfoViewModel.vala 0% <0%> (ø)
src/view/ApplicationWindow.vala 0% <0%> (ø)
src/tox/ToxContact.vala 72.72% <0%> (ø) ⬆️
src/tox/ToxAdapterFriendListener.vala 0% <0%> (ø)
src/view/UserInfoWidget.vala 0% <0%> (ø)
src/viewmodel/FriendInfoViewModel.vala 0% <0%> (ø)
src/viewmodel/ContactListViewModel.vala 0% <0%> (ø)
src/tox/ToxAdapterSelfListener.vala 0% <0%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc92e2...83e1d19. Read the comment docs.

@naxuroqa naxuroqa merged commit 83e1d19 into develop May 14, 2018
@naxuroqa naxuroqa deleted the VENOM-361_distribute_avatar branch May 14, 2018 12:10
@naxuroqa naxuroqa changed the title Venom-361: Distribute avatar VENOM-361: Distribute avatar May 19, 2018
SkyzohKey pushed a commit to SkyzohKey/Venom that referenced this pull request Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distribute your own avatar to friends
2 participants