Add pre-commit hook running Prettier #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Husky to configure git hooks and lint-staged to configure commands to run against staged files
7er
approved these changes
Oct 1, 2020
package.json
Outdated
| } | ||
| }, | ||
| "lint-staged": { | ||
| "*.{js,jsx}": [ |
There was a problem hiding this comment.
vi vil sikkert ha med cjs og mjs også som default.
it-vegard
deleted the
feature/add-pre-commit-hook-using-husky-and-lint-staged
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Husky to configure git hooks and lint-staged to configure commands to run against staged files
Using Husky v3.1, because version 4.x no longer uses run-node, resulting in each user having to add path variables, etc. to make it run. If not, version 4 fails silently, which is not a good idea for a project that is built on the premise of working out of the box.
See typicode/husky#639
If this is fixed in the future, we can upgrade, but we don't lose much by being on a major version below latest.
NB! This still requires that everyone runs
npm install