Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/blokker sletting nar loading #343

Merged
merged 22 commits into from
Sep 23, 2024

Conversation

nils-arne
Copy link
Contributor

No description provided.

…ort feilmelding, og fikset feil hvis validering feiler på filstørrelse
@nils-arne nils-arne requested a review from akgagnat September 19, 2024 13:49
@nils-arne nils-arne requested a review from a team as a code owner September 19, 2024 13:49
Copy link
Member

@akgagnat akgagnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sjekk hvordan vi kan legge på testdekning på dette

@@ -127,6 +127,7 @@ export interface FilProps {
lokalFil?: File;
opplastetFil?: OpplastetFil;
filListeDispatch: React.Dispatch<ActionType>;
lasterOppStateDispoatch: React.Dispatch<number>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Dispoatch

axios
.delete(`${publicRuntimeConfig.apiUrl}/frontend/v1/soknad/${soknad.innsendingsId}/vedlegg/${vedleggsId}`)

const slettAnnetVedlegg = async (harAktiveEndringer: boolean, vedleggsId: number) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flytt harAktiveEndringer param etter vedleggsId

const slettAnnetVedlegg = async (harAktiveEndringer: boolean, vedleggsId: number) => {
if (harAktiveEndringer) return;

await nyLagringsProsess(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prøv uten await og async

@nils-arne nils-arne merged commit 99869d5 into main Sep 23, 2024
4 checks passed
@nils-arne nils-arne deleted the feature/blokker-sletting-nar-loading branch September 23, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants