Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller for kontaktinfo #330

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Controller for kontaktinfo #330

merged 8 commits into from
Oct 13, 2023

Conversation

peterbb
Copy link
Contributor

@peterbb peterbb commented Oct 10, 2023

Bygger på

Testet i dev ✅


Ser at ObjectMapper i spring er annerledes enn default fra jackson.

  • Konverterer mellom skalarer (number -> string)
  • Godtar ukjente properties

Jeg liker i hvert fall ikke første, og ønsker helst opt-in for den andre.

Ser ut til at et er ganske mange måter å konfigurere ObjectMapper på i spring: https://www.baeldung.com/spring-boot-customize-jackson-objectmapper Har ikke satt meg inn i det enda.

@peterbb peterbb requested a review from a team as a code owner October 10, 2023 14:47
@kenglxn
Copy link
Contributor

kenglxn commented Oct 10, 2023

Ser at ObjectMapper i spring er annerledes enn default fra jackson.

  • Konverterer mellom skalarer (number -> string)
  • Godtar ukjente properties

Jeg liker i hvert fall ikke første, og ønsker helst opt-in for den andre.

Ser ut til at et er ganske mange måter å konfigurere ObjectMapper på i spring: https://www.baeldung.com/spring-boot-customize-jackson-objectmapper Har ikke satt meg inn i det enda.

Jackson2ObjectMapperBuilderCustomizer de har er ganske greit synes jeg.

@peterbb peterbb changed the base branch from master to tilgangsstyring_roller October 12, 2023 19:56
@peterbb
Copy link
Contributor Author

peterbb commented Oct 13, 2023

Syntest det ble litt skummelt å introdusere endring i objectmapper for hele appen (eller alle http-requests i hvert fall), så tenker jeg ikke tar det med i denne PR-en.

Base automatically changed from tilgangsstyring_roller to master October 13, 2023 10:12
@peterbb peterbb merged commit 460a0ba into master Oct 13, 2023
4 checks passed
@peterbb peterbb deleted the TAG-2161-api-spec branch October 13, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants