IS-3066: Use valkey-cache #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private val redisConfig = environment.redisConfig | ||
| val redisCache = RedisStore( | ||
| private val redisConfig = environment.valkeyConfig | ||
| val redisCache = ValkeyStore( |
There was a problem hiding this comment.
cache eller valkeyStore?
Suggested change
| val redisCache = ValkeyStore( | |
| val cache = ValkeyStore( |
There was a problem hiding this comment.
Vi bruker faktisk en test-redis her (embedded-redis), så tenker det er greit at det fortsatt er reflektert i navnet..
andersrognstad
approved these changes
Feb 6, 2025
| .build() | ||
| ) | ||
| ) | ||
| val redisServer = testRedis(environment) | ||
| val redisServer = testValkey(environment) |
There was a problem hiding this comment.
cacheServer eller bare valkeyServer? 😊
Suggested change
| val redisServer = testValkey(environment) | |
| val cacheServer = testValkey(environment) |
There was a problem hiding this comment.
Vi bruker faktisk en test-redis her (embedded-redis), så tenker det er greit at det fortsatt er reflektert i navnet..
vetlesolgaard
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bytter til Valkey cache på Aiven