Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump avhengigheter #785

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Bump avhengigheter #785

merged 5 commits into from
Nov 22, 2024

Conversation

bjerga
Copy link
Contributor

@bjerga bjerga commented Nov 20, 2024

🫕

@bjerga bjerga requested a review from a team as a code owner November 20, 2024 13:58
prometheusVersion=0.16.0
rapidsAndRiversTestVersion=2024.09.23-08.33-8839f9a1
rapidsAndRiversTestVersion=2024.11.19-09.27-9c591574
rapidsAndRiversVersion=2024082715011724763661.50d7efb40f0f
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oppdaterer ikke denne fordi det ofte fører med seg krøll. Bør nok tas for seg selv.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test brakk også 😐

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fjernet oppdateringen av testversjonen av R&R også, fordi det så ut som at avhengigheter de delte hadde ulike versjoner.

Copy link
Contributor Author

@bjerga bjerga Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlin-versjonen før 2.0.10 hadde en bug i avhengighetslogikken som førte til at avhengigheter ble propagert i tilfeller der det ikke skulle det. Når vi oppdaterte til Kotlin 2.0.10 så brakk testene fordi vi plutselig manglet avhengigheter, men det ble løst ved å legge til direkte avhengigheter der det manglet.

@bjerga bjerga marked this pull request as draft November 20, 2024 14:15
@bjerga
Copy link
Contributor Author

bjerga commented Nov 21, 2024

Testet OK.

@bjerga bjerga marked this pull request as ready for review November 21, 2024 10:41
@bjerga bjerga requested a review from mortenbyhring November 21, 2024 10:41
@bjerga bjerga merged commit 4d9b60b into main Nov 22, 2024
74 checks passed
@bjerga bjerga deleted the dev/bump-avhengigheter branch November 22, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants