Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Using 'loader' inside 'icon'-prop broke layout caused by position absolute #3515

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Jan 21, 2025

Description

Resolves https://nav-it.slack.com/archives/C7NE7A8UF/p1737462476282339

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

@KenAJoh KenAJoh self-assigned this Jan 21, 2025
Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 068156f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Storybook demo / Chromatic

7151a4990 | 91 components | 135 stories

@KenAJoh KenAJoh merged commit d29509d into main Jan 22, 2025
6 checks passed
@KenAJoh KenAJoh deleted the button-icon-loader branch January 22, 2025 10:19
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants