Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always render the maxSelected message when isMultiSelect #3506

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

JulianNymark
Copy link
Contributor

@JulianNymark JulianNymark commented Jan 17, 2025

Description

closes https://github.com/navikt/team-aksel/issues/688

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: eb5aef8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Storybook demo / Chromatic

eff29915f | 91 components | 135 stories

KenAJoh
KenAJoh previously approved these changes Jan 20, 2025
Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, if limit is set to 0 this won't work. But there are bigger issues elsewhere if you would end up setting limit to 0 so think we can ignore it.

Remember changeset!

@KenAJoh KenAJoh merged commit 715a34a into main Jan 22, 2025
6 checks passed
@KenAJoh KenAJoh deleted the combobox-message-layout-shift branch January 22, 2025 08:02
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants