Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox: Removed clear button, deprecated props clearButton/clearButtonLabel, changed maxSelected to number. #3433

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Dec 6, 2024

TODO: Remove clear key from translations after i18n PR has been merged, or merge this first and remove it in the i18n PR.

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: cf0494e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/aksel-stylelint Minor
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Storybook demo / Chromatic

📝 Endringer til review: 1

ff641ca8f | 91 komponenter | 135 stories

@HalvorHaugan HalvorHaugan changed the title Combobox: Deprecated props clearButton and clearButtonLabel, and changed maxSelected to number. Combobox: Removed clear button, deprecated props clearButton/clearButtonLabel, changed maxSelected to number. Dec 6, 2024
@HalvorHaugan HalvorHaugan marked this pull request as ready for review December 6, 2024 13:36
KenAJoh
KenAJoh previously approved these changes Dec 6, 2024
Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 🚢

.changeset/quick-seas-press.md Outdated Show resolved Hide resolved
@HalvorHaugan HalvorHaugan merged commit f720562 into main Dec 6, 2024
5 checks passed
@HalvorHaugan HalvorHaugan deleted the combobox-remove-clear branch December 6, 2024 15:33
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants