Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] Added FileJpeg and FilePng. #3332

Merged
merged 3 commits into from
Nov 8, 2024
Merged

[Icons] Added FileJpeg and FilePng. #3332

merged 3 commits into from
Nov 8, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Nov 6, 2024

Description

Resolves #3142
Resolves #3141

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

@KenAJoh KenAJoh requested review from a team as code owners November 6, 2024 12:47
Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: cbf0af9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/aksel-icons Minor
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel Minor
@navikt/aksel-stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Storybook demo / Chromatic

📝 Endringer til review: 2

f656e74db | 91 komponenter | 144 stories

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser ut som en pipette spør du meg 😝

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can omit this icon from the PR, so that we can take a quick review of it before adding it 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, JK ;)

HalvorHaugan
HalvorHaugan previously approved these changes Nov 8, 2024
@KenAJoh KenAJoh changed the title [Icons] Added FileJpeg, FilePng and MedicalThermometer. [Icons] Added FileJpeg and FilePng. Nov 8, 2024
@KenAJoh KenAJoh merged commit 47a4dd6 into main Nov 8, 2024
3 checks passed
@KenAJoh KenAJoh deleted the icon-update-nov-2024 branch November 8, 2024 09:52
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nytt ikon]: Filtype PNG [Nytt ikon]: Filtype JPEG
2 participants